-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete compilation.tar.gz after extracting for windows pipeline #25168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7403532686
💛 - Coveralls |
Charles-Gagnon
approved these changes
Jan 3, 2024
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
@@ -28,6 +28,8 @@ steps: | |||
. build/azure-pipelines/win32/exec.ps1 | |||
$ErrorActionPreference = "Stop" | |||
exec { tar -xf $(Pipeline.Workspace)/compilation.tar.gz } | |||
# Delete compiled tarball now that we've extracted the files since it takes up a lot of space | |||
exec { rm $(Pipeline.Workspace)/compilation.tar.gz } | |||
displayName: Extract compilation output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried using the ExtractFiles@1 task as VS Code does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nvm, you'd still need to call DeleteFiles@1
cheenamalhotra
approved these changes
Jan 3, 2024
siyao-Siyang
pushed a commit
that referenced
this pull request
Jan 11, 2024
* delete compilation.tar.gz after extracting for windows pipeline * Update build/azure-pipelines/win32/sql-product-build-win32.yml Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> --------- Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The windows builds started consistently failing on the initial run over a week ago with the error "There is not enough space on the disk". This should free up space, similar to fix made a couple months ago for linux builds in #24539.
Adhoc build (with signing enabled like the nightly product build): https://mssqltools.visualstudio.com/CrossPlatBuildScripts/_build/results?buildId=219026&view=logs&j=471dc74f-2452-533b-c058-e43cd1b98abf&t=69447ecb-e768-5cc0-89bc-3e5a8b725059