Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a cancellation confirmation dialog with an optional feedback option. #25197

Merged
merged 14 commits into from
Feb 20, 2024

Conversation

krritik
Copy link
Contributor

@krritik krritik commented Jan 11, 2024

Aim:
Enhance the cancellation experience by implementing a confirmation dialog when users click the Cancel button. This dialog prompts users to confirm their cancellation choice and optionally provide feedback. Integrated across relevant pages, it offers default cancellation reasons tailored to each context and allows users to input custom reasons.

Actions Completed:

  1. Created a new confirmation dialog for cancelling actions.
  2. Integrated a feedback option within the cancellation confirmation dialog, offering dynamic options.
  3. Developed a custom cancel button for the wizard controller to trigger the cancellation confirmation dialog instead of immediate cancellation.
  4. Implemented the cancellation confirmation dialog with distinct cancellation reasons for various wizard pages.
  5. Extended the cancellation confirmation dialog to cover cancellation after migration initiation.
  6. Incorporated the cancellation confirmation dialog into different login migration pages for consistency and improved user experience.

Implementation :

  1. Utilized radio buttons and an input box for feedback options, catering to both predefined and custom reasons.
  2. Incorporated callback functions to handle dialog confirmation, ensuring adaptability across different scenarios.
  3. Implemented callback functions in the WizardController to track cancellation events, providing valuable insights for analysis.
  4. Replaced default cancel buttons with custom ones, initiating the cancellation dialog for a consistent user experience.

image
image
image

@coveralls
Copy link

coveralls commented Jan 11, 2024

Pull Request Test Coverage Report for Build 7622548951

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 41.758%

Totals Coverage Status
Change from base Build 7482522687: -0.004%
Covered Lines: 30827
Relevant Lines: 69081

💛 - Coveralls

Copy link
Contributor

@Ramudaykumar Ramudaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@krritik krritik merged commit 3ba2110 into main Feb 20, 2024
14 checks passed
@krritik krritik deleted the krritik/updateCancellationFeedback branch February 20, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants