Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes azure account detection to work with email address #25199

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Jan 11, 2024

Fixes command-line behavior where email address wouldn't work when trying to connect using Azure MFA.

E.g.
azuredatastudio --server <serverName> --authenticationType AzureMFA --user <email address> --command connect

Before:
Launches ADS, but doesn't connect immediately, opens connection dialog instead. Below errors are captured in logs:

Could not find Azure account with name undefined
Failed to connect due to error: Error

After:
Launches ADS and creates a new connection if email address is found associated with an Azure account.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7491693434

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.762%

Totals Coverage Status
Change from base Build 7482522687: 0.0%
Covered Lines: 30827
Relevant Lines: 69073

💛 - Coveralls

@cheenamalhotra cheenamalhotra merged commit 6314886 into main Jan 15, 2024
15 checks passed
@cheenamalhotra cheenamalhotra deleted the cheena/fix-cmdline-azure-mfa branch January 15, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants