Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL Migration] Schema migration support Windows login #25202

Merged
merged 6 commits into from
Jan 12, 2024

Conversation

siyao-Siyang
Copy link
Contributor

@siyao-Siyang siyao-Siyang commented Jan 11, 2024

Background:
SHIR 5.37.8767.4 (Will be released on 1/12/2024) supports Windows login to connect source instance. Therefore, update the schema migration info message and validation.

Changes:

  1. Update the info message in step 4.
    image

  2. Update the schema migration validation. 5.37 is the min version supporting schema migration.
    image
    image

@coveralls
Copy link

coveralls commented Jan 11, 2024

Pull Request Test Coverage Report for Build 7494494700

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.762%

Totals Coverage Status
Change from base Build 7482522687: 0.0%
Covered Lines: 30827
Relevant Lines: 69073

💛 - Coveralls

@siyao-Siyang siyao-Siyang merged commit 3567c6c into main Jan 12, 2024
14 checks passed
@siyao-Siyang siyao-Siyang deleted the users/siyao/remove-win-validation branch January 12, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants