Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependabot alerts #25262

Merged
merged 6 commits into from
Jan 26, 2024
Merged

Fix dependabot alerts #25262

merged 6 commits into from
Jan 26, 2024

Conversation

@kisantia
Copy link
Contributor

Looks like there was a breaking change in the version bump, causing the compilation failure. I think this package is just used for adding the port request labels, so it should be ok to comment out the places with errors if the fix isn't very obvious, then fix those in a separate PR to unblock the builds sooner.

@coveralls
Copy link

coveralls commented Jan 25, 2024

Pull Request Test Coverage Report for Build 7672667765

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.759%

Totals Coverage Status
Change from base Build 7671914414: 0.0%
Covered Lines: 30828
Relevant Lines: 69082

💛 - Coveralls

@SakshiS-harma
Copy link
Contributor Author

@kisantia, @Charles-Gagnon, @alanrenmsft The PR looks good to go now from my end. Can you take a pass on this, so that the builds can go through? Thanks!

@SakshiS-harma SakshiS-harma merged commit 66cb3fb into main Jan 26, 2024
12 checks passed
@SakshiS-harma SakshiS-harma deleted the sakshis/fixDependabotAlert branch January 26, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants