Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal dialogs become unreadable after applying max zoom #25293

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

barbaravaldez
Copy link
Contributor

@barbaravaldez barbaravaldez commented Feb 5, 2024

For: #25124

I needed to add an extra div to include the scrollbar to the dialog content and the dialog footer.

image

image

Adding more examples of this:

Adding a database user
image

image

Restore database
image

image

Deployment options wizard:

image

image

@coveralls
Copy link

coveralls commented Feb 5, 2024

Pull Request Test Coverage Report for Build 7792935287

  • 0 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 41.766%

Totals Coverage Status
Change from base Build 7790722680: 0.007%
Covered Lines: 30833
Relevant Lines: 69083

💛 - Coveralls

@barbaravaldez barbaravaldez changed the title add horizontal scrollbar to server and database properties modal Modal dialogs become unreadable after applying max zoom Feb 5, 2024
@corivera
Copy link
Member

corivera commented Feb 6, 2024

Does the base modal change also affect other core dialogs like Connection Dialog? Basically any of the ones extending the Modal class.

@barbaravaldez
Copy link
Contributor Author

Does the base modal change also affect other core dialogs like Connection Dialog? Basically any of the ones extending the Modal class.
yes, it does and we can see the same behavior in other dialogs as well.

@corivera
Copy link
Member

corivera commented Feb 6, 2024

@barbaravaldez could you give some more details about the various style changes and why they're needed?

@kisantia
Copy link
Contributor

kisantia commented Feb 6, 2024

Also please add a screenshot of any other flyout dialogs that would be affected by this change.

@barbaravaldez
Copy link
Contributor Author

barbaravaldez commented Feb 6, 2024

Also please add a screenshot of any other flyout dialogs that would be affected by this change.

@kisantia, since I'm modifying the modal dialogs. I think it's most of them. The ones I know that are not being modified are the callout dialog, the connection dialog, and the select blob storage dialog.

@barbaravaldez
Copy link
Contributor Author

@barbaravaldez could you give some more details about the various style changes and why they're needed?

@corivera, to add the scrollbar I added the overflow-x but that alone does not add a scrollbar. I needed to add the max-width to 100%, so that the size of the dialog doesn't exceed that and also, I had to add the display:contents so all the dialog components such as the (header, body, and footer) stay visible.

@barbaravaldez
Copy link
Contributor Author

barbaravaldez commented Feb 6, 2024

Does the base modal change also affect other core dialogs like Connection Dialog? Basically any of the ones extending the Modal class.

@corivera, Sorry I missed this! It doesn't seem to affect the Connection Dialog.

@barbaravaldez barbaravaldez merged commit a2ecb5f into main Feb 7, 2024
14 checks passed
@barbaravaldez barbaravaldez deleted the bavaldez/scrollbar branch February 7, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants