-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal dialogs become unreadable after applying max zoom #25293
Conversation
Pull Request Test Coverage Report for Build 7792935287
💛 - Coveralls |
Does the base modal change also affect other core dialogs like Connection Dialog? Basically any of the ones extending the Modal class. |
|
@barbaravaldez could you give some more details about the various style changes and why they're needed? |
Also please add a screenshot of any other flyout dialogs that would be affected by this change. |
@kisantia, since I'm modifying the modal dialogs. I think it's most of them. The ones I know that are not being modified are the callout dialog, the connection dialog, and the select blob storage dialog. |
@corivera, to add the scrollbar I added the overflow-x but that alone does not add a scrollbar. I needed to add the max-width to 100%, so that the size of the dialog doesn't exceed that and also, I had to add the display:contents so all the dialog components such as the (header, body, and footer) stay visible. |
@corivera, Sorry I missed this! It doesn't seem to affect the Connection Dialog. |
For: #25124
I needed to add an extra div to include the scrollbar to the dialog content and the dialog footer.
Adding more examples of this:
Adding a database user
![image](https://private-user-images.githubusercontent.com/34872381/302458271-34d5aef6-f0d3-4c83-8e93-97b234c8f976.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1NzUzMTQsIm5iZiI6MTcyMDU3NTAxNCwicGF0aCI6Ii8zNDg3MjM4MS8zMDI0NTgyNzEtMzRkNWFlZjYtZjBkMy00YzgzLThlOTMtOTdiMjM0YzhmOTc2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEwVDAxMzAxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdmYjE0N2RhY2RmMTQzMzA5MmMxMzdiYTUxMTUzMmJjYjM1NTdkMWEzMTE4OWZiM2NiZDEzMGM3NWI1MTBlM2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.SgebhLGP-lPaMb02i9aUTiqh2seNSVnIDT8YZjtuWCQ)
Restore database
![image](https://private-user-images.githubusercontent.com/34872381/302458425-42109a27-7620-446e-9d2a-a77d25c20a34.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1NzUzMTQsIm5iZiI6MTcyMDU3NTAxNCwicGF0aCI6Ii8zNDg3MjM4MS8zMDI0NTg0MjUtNDIxMDlhMjctNzYyMC00NDZlLTlkMmEtYTc3ZDI1YzIwYTM0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEwVDAxMzAxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFjMzgzNDk1YzVlM2I1YTljYjA5MGIyN2VjYjY2ZGZhZDkwNGEyZjQzNjVjYTZjYWRkMWRlMGIwNTc2YjkxOGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.K_1WgvOz4_GrRDPDfTUEC1QEFnUb-bNOsjeGwor0LSU)
Deployment options wizard: