Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks for undefined #25302

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Add checks for undefined #25302

merged 1 commit into from
Feb 7, 2024

Conversation

barbaravaldez
Copy link
Contributor

-Add some checks to verify that S3 Url dialog result is not undefined

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7811537143

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 41.759%
Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/dialog/configurePython/configurePathPage.ts 1 57.02%
Totals Coverage Status
Change from base Build 7808712200: -0.001%
Covered Lines: 30828
Relevant Lines: 69082
💛 - Coveralls

@barbaravaldez barbaravaldez merged commit 8fc6ca4 into main Feb 7, 2024
15 checks passed
@barbaravaldez barbaravaldez deleted the bavaldez/addValidations branch February 7, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corivera corivera corivera approved these changes

@kisantia kisantia Awaiting requested review from kisantia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@barbaravaldez @coveralls @corivera