Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QDS ADS integration #25306

Merged
merged 4 commits into from
Feb 27, 2024
Merged

QDS ADS integration #25306

merged 4 commits into from
Feb 27, 2024

Conversation

stuti149
Copy link
Contributor

@stuti149 stuti149 commented Feb 8, 2024

This PR:

Adds UI to ask customer to collect Ad-hoc queries using QDS and based on selection send boolean parameter to service to trigger collection and extraction.

image

Testing:

When Collect ad hoc query using QDS : we have following output true coming from nuget
image

@coveralls
Copy link

coveralls commented Feb 8, 2024

Pull Request Test Coverage Report for Build 8043764828

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 105 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.004%) to 41.757%

Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/dialog/configurePython/configurePathPage.ts 1 57.02%
extensions/notebook/src/jupyter/jupyterServerInstallation.ts 104 47.63%
Totals Coverage Status
Change from base Build 7820044376: -0.004%
Covered Lines: 30827
Relevant Lines: 69082

💛 - Coveralls

@Ramudaykumar
Copy link
Contributor

QDS is available from 2016 and above? why this msg saying 2019?

image

@Ramudaykumar
Copy link
Contributor

I didn't see any PR in sqltoolsservice to get latest SQL NuGet and Sqltoolsservice version upgrade here? How is this getting done?

@stuti149
Copy link
Contributor Author

stuti149 commented Feb 8, 2024

I didn't see any PR in sqltoolsservice to get latest SQL NuGet and Sqltoolsservice version upgrade here? How is this getting done?

@Ramudaykumar

microsoft/sqltoolsservice#2322

@stuti149
Copy link
Contributor Author

stuti149 commented Feb 8, 2024

QDS is available from 2016 and above? why this msg saying 2019?

image

Screenshot is older one, strings are updated. Will update SS as well.

@Ramudaykumar
Copy link
Contributor

I didn't see any PR in sqltoolsservice to get latest SQL NuGet and Sqltoolsservice version upgrade here? How is this getting done?

@Ramudaykumar

microsoft/sqltoolsservice#2322

Thanks, I have approved it, you will need to run official build of SQLToolsservie and update latest version in extensions/sql-migration/package.json.

@Ramudaykumar
Copy link
Contributor

QDS is available from 2016 and above? why this msg saying 2019?
image

Screenshot is older one, strings are updated. Will update SS as well.

Thanks, I can see in code. You may update the screenshot as it may confuse other reviewers as well.

@stuti149 stuti149 merged commit a258a74 into main Feb 27, 2024
14 checks passed
@stuti149 stuti149 deleted the stutijain/QDS-integration branch February 27, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants