Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update encryption option strings in ADS connection dialog #25311

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Update encryption option strings in ADS connection dialog #25311

merged 2 commits into from
Feb 9, 2024

Conversation

kisantia
Copy link
Contributor

@kisantia kisantia commented Feb 8, 2024

Fixes #25310.

  • order the entries from least to most secure (default is still Mandatory)
  • update the text for the options, based on recent discussions
    image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7836167725

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 41.759%
Totals Coverage Status
Change from base Build 7834283255: 0.002%
Covered Lines: 30829
Relevant Lines: 69083
💛 - Coveralls

@kisantia kisantia merged commit 471a0e3 into main Feb 9, 2024
14 checks passed
@kisantia kisantia deleted the kisantia/updateEncryptStrings branch February 9, 2024 17:29
@kisantia kisantia mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shueybubbles shueybubbles shueybubbles approved these changes

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@erinstellato-ms erinstellato-ms erinstellato-ms approved these changes

@Matteo-T Matteo-T Awaiting requested review from Matteo-T

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update encrypt dropdown in connection dialog
5 participants
@kisantia @coveralls @shueybubbles @cheenamalhotra @erinstellato-ms