Remove empty Provided Books view #25318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2092,6 +2092,11 @@ export class SearchView extends ViewPane { | |||
| } | |||
|
|
|||
| private _saveSearchHistoryService() { | |||
| // {{SQL CARBON EDIT}} | |||
There was a problem hiding this comment.
Please add a comment with a description and link to the issue where this was fixed in VS Code so we know to remove the edit tag once that commit is brought in.
Charles-Gagnon
approved these changes
Feb 13, 2024
kisantia
approved these changes
Feb 13, 2024
Pull Request Test Coverage Report for Build 7880237784Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24427
Also fixed an issue I was seeing in the console log where errors were being thrown due to
searchWidgetbeing undefined insearchView.ts. A similar fix was already made in vscode here: microsoft/vscode@c410d55