Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty package list during python installation #25332

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

corivera
Copy link
Member

Fixes #25049

If there's an error when retrieving the list of python packages we return an empty array instead. In most places we iterate over this list, so being empty isn't an issue. In this spot we were using a find call though, which would return undefined when the array is empty. This change adds an undefined check before using the results of that find call.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7936952128

Details

  • -3 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 41.757%

Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/notebook/src/jupyter/jupyterServerInstallation.ts 0 3 0.0%
Totals Coverage Status
Change from base Build 7934141412: -0.001%
Covered Lines: 30827
Relevant Lines: 69082

💛 - Coveralls

@corivera corivera merged commit 5a87a75 into main Feb 16, 2024
15 checks passed
@corivera corivera deleted the corivera/packageError branch February 16, 2024 23:55
@corivera
Copy link
Member Author

corivera commented Feb 16, 2024

I'll go ahead and merge this without waiting for sign offs, since people are out for the long weekend and it's a pretty simple change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not able to select notebook - python
2 participants