Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom options selection event #25380

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Feb 22, 2024

Addresses #25378

Use Widget's value instead of value provided by selection event, which is diaplay value by design.

image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8009143295

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • -2 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 41.759%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sql/workbench/services/connection/browser/connectionWidget.ts 0 2 0.0%
Totals Coverage Status
Change from base Build 8008775528: 0.002%
Covered Lines: 30828
Relevant Lines: 69082

💛 - Coveralls

@cheenamalhotra cheenamalhotra merged commit 4244d9f into main Feb 22, 2024
11 of 15 checks passed
@cheenamalhotra cheenamalhotra deleted the cheena/fix-strict-encryption branch February 22, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants