Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing nvda browse mode in query plan #25423

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Fixing nvda browse mode in query plan #25423

merged 2 commits into from
Feb 28, 2024

Conversation

aasimkhan30
Copy link
Contributor

@aasimkhan30 aasimkhan30 commented Feb 27, 2024

For some reason, nvda browse mode wasn't working when I set query plan's role as tree view. However, changing the role to 'group' made it work.
Issue: #20777

@coveralls
Copy link

coveralls commented Feb 27, 2024

Pull Request Test Coverage Report for Build 8069913175

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 41.756%

Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/dialog/configurePython/configurePythonWizard.ts 1 46.46%
Totals Coverage Status
Change from base Build 8060407785: -0.001%
Covered Lines: 30826
Relevant Lines: 69082

💛 - Coveralls

@kisantia
Copy link
Contributor

does this also need a distro bump?

@aasimkhan30
Copy link
Contributor Author

@kisantia , we don't need to update the distro. I just had to make vbump the same azdata graph package in web and remote.

@aasimkhan30 aasimkhan30 merged commit a584009 into main Feb 28, 2024
14 checks passed
@aasimkhan30 aasimkhan30 deleted the aasim/fix/20777 branch February 28, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants