Target Provisioning #25426
Merged
Target Provisioning #25426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahuroshan
requested review from
krritik,
RamyaR29,
stuti149,
cpichuka and
Ramudaykumar
sahuroshan
requested review from
AkshayMata,
raymondtruong,
brian-harris and
junierch
as code owners
Pull Request Test Coverage Report for Build 8340151881Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
...nsions/sql-migration/src/dialog/skuRecommendationResults/GenerateProvisioningScriptDialog.ts
Outdated
Show resolved
Hide resolved
|
|
||
| this._saveTemplateLink.onDidClick(async () => { | ||
| if (hasRecommendations(this.migrationStateModel)) { | ||
| const generateProvisioningScriptDialog = new GenerateProvisioningScriptDialog(this.migrationStateModel, this.migrationTargetType); |
There was a problem hiding this comment.
Use Try catch here to catch any error, and log it. It will be helpful while debugging.
extensions/sql-migration/src/wizard/assessmentDetailsPage/assessmentDetailsHeader.ts
Outdated
Show resolved
Hide resolved
| containerName, | ||
| blobName, | ||
| permissions: BlobSASPermissions.parse("racwd"), | ||
| expiresOn: new Date(new Date().valueOf() + 86400), |
There was a problem hiding this comment.
are we expecting 24 Hours expiration?
There was a problem hiding this comment.
I just used some random value, can change based on suggestion.
extensions/sql-migration/src/dialog/skuRecommendationResults/SelectStorageAccountDialog.ts
Outdated
Show resolved
Hide resolved
| azdata.window.openDialog(this.dialog); | ||
| await Promise.all(dialogSetupPromises); | ||
|
|
||
| await this.model.getArmTemplate(this._targetType); |
There was a problem hiding this comment.
this must be under try catch block. and log error if it fails.
There was a problem hiding this comment.
there is a try catch block in the getArmTemplate function and error is also logged .
...nsions/sql-migration/src/dialog/skuRecommendationResults/GenerateProvisioningScriptDialog.ts
Outdated
Show resolved
Hide resolved
stuti149
reviewed
Feb 28, 2024
...nsions/sql-migration/src/dialog/skuRecommendationResults/GenerateProvisioningScriptDialog.ts
Outdated
Show resolved
Hide resolved
...nsions/sql-migration/src/dialog/skuRecommendationResults/GenerateProvisioningScriptDialog.ts
Outdated
Show resolved
Hide resolved
extensions/sql-migration/src/dialog/skuRecommendationResults/SelectStorageAccountDialog.ts
Outdated
Show resolved
Hide resolved
extensions/sql-migration/src/wizard/assessmentDetailsPage/assessmentDetailsHeader.ts
Show resolved
Hide resolved
extensions/sql-migration/src/wizard/assessmentDetailsPage/assessmentDetailsHeader.ts
Show resolved
Hide resolved
stuti149
approved these changes
Mar 18, 2024
|
|
||
| // source instance same would be same across all recommendations MI/DB/VM. | ||
| let instanceName = model._skuRecommendationResults.recommendations?.sqlMiRecommendationResults[0].sqlInstanceName; | ||
| let fileName = `ARMTemplate-${targetType}-${instanceName}-${date}-${time}.json`; |
There was a problem hiding this comment.
looks good to me, hope name is recommended or approved by PM, as this customer facing.
added 2 commits
March 18, 2024 23:20
...nsions/sql-migration/src/dialog/skuRecommendationResults/GenerateProvisioningScriptDialog.ts
Outdated
Show resolved
Hide resolved
|
Update config.json under sql-migration extension with latest sqltoolsservice build version. |
krritik
reviewed
Mar 18, 2024
krritik
reviewed
Mar 18, 2024
extensions/sql-migration/src/wizard/skuRecommendation/assessmentSummaryCard.ts
Outdated
Show resolved
Hide resolved
krritik
reviewed
Mar 18, 2024
extensions/sql-migration/src/wizard/assessmentDetailsPage/assessmentDetailsHeader.ts
Outdated
Show resolved
Hide resolved
Ramudaykumar
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains following changes
UI changes for target provisioning experience as per below mocks.
Mocks - https://www.figma.com/file/UaD2zc58Y2iGKxnqDFQY3Q/End-to-End-Design-GA---SQL-Migration-ADS?type=design&node-id=3298-119337&mode=design&t=v0BLyTpg5zdjtnlu-0
Added RPC Request(GetSqlMigrationGenerateArmTemplateRequest) for the SQL tools service GenerateProvsioningScript API which generates the ARM Template.
Reference code for generating SAS URI to upload ARM template.
https://github.com/Azure-Samples/AzureStorageSnippets/blob/master/blobs/howto/JavaScript/NodeJS-v12/dev-guide/upload-blob-from-blob-sas-token.js
Screenshots of changes
1.