Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in missed changes for databaseDialog #25430

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

smartguest
Copy link
Contributor

@smartguest smartguest commented Feb 27, 2024

Changes were already approved, just that they weren't actually included in the PR: #25325 This PR actually adds in the new declarative table. The changes made to databaseDialog were accidentally removed while trying to revert it to an earlier version

@coveralls
Copy link

coveralls commented Feb 27, 2024

Pull Request Test Coverage Report for Build 8072194637

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 41.756%

Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/dialog/configurePython/configurePythonWizard.ts 1 46.46%
Totals Coverage Status
Change from base Build 8060407785: -0.001%
Covered Lines: 30826
Relevant Lines: 69082

💛 - Coveralls

@smartguest smartguest merged commit 7703840 into main Feb 27, 2024
12 of 14 checks passed
@smartguest smartguest deleted the alex/adddeclarativerowsfilegroups2-27-2024 branch February 27, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants