Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable QDS on UI #25433

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Disable QDS on UI #25433

merged 2 commits into from
Feb 28, 2024

Conversation

stuti149
Copy link
Contributor

image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8076796857

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 41.756%
Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/dialog/configurePython/configurePythonWizard.ts 1 46.46%
Totals Coverage Status
Change from base Build 8076359343: -0.001%
Covered Lines: 30826
Relevant Lines: 69082
💛 - Coveralls

Ramudaykumar
Ramudaykumar reviewed Feb 28, 2024
View reviewed changes
extensions/sql-migration/src/constants/strings.ts
@@ -92,7 +92,7 @@ export const DATABASE_FOR_ASSESSMENT_DESCRIPTION = localize('sql.migration.datab

// XEvents assessment
export const XEVENTS_ASSESSMENT_TITLE = localize('sql.migration.database.assessment.xevents.title', "Assess Ad-hoc or dynamic SQL");
export const XEVENTS_ASSESSMENT_DESCRIPTION = localize('sql.migration.database.assessment.xevents.description', "For the selected databases, select the option you want to assess ad-hoc or dynamic SQL queries or any DML statements initiated through the application data layer. {0}");
export const XEVENTS_ASSESSMENT_DESCRIPTION = localize('sql.migration.database.assessment.xevents.description', "For the selected databases, optionally provide extended event session files to assess ad-hoc or dynamic SQL queries or any DML statements initiated through the application data layer.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was needed for showing previous message, right? will need to revert this change as well while enabling it for next release?

Ramudaykumar
Ramudaykumar approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@Ramudaykumar Ramudaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good me, approving it with question. No change needed in PR.

@stuti149
Copy link
Contributor Author

Looks good me, approving it with question. No change needed in PR.

yes

@stuti149 stuti149 merged commit e41d03a into main Feb 28, 2024
14 checks passed
@stuti149 stuti149 deleted the stutijain/disableQS branch February 28, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ramudaykumar Ramudaykumar Ramudaykumar approved these changes

@AkshayMata AkshayMata Awaiting requested review from AkshayMata AkshayMata is a code owner

@raymondtruong raymondtruong Awaiting requested review from raymondtruong raymondtruong is a code owner

@brian-harris brian-harris Awaiting requested review from brian-harris brian-harris is a code owner

@junierch junierch Awaiting requested review from junierch junierch is a code owner

@krritik krritik Awaiting requested review from krritik

@RamyaR29 RamyaR29 Awaiting requested review from RamyaR29

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stuti149 @coveralls @Ramudaykumar