Bug fix of single click SHIR #25449
Merged
Bug fix of single click SHIR #25449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
February 21, 2024 00:44
RamyaR29
requested review from
AkshayMata,
raymondtruong,
brian-harris and
junierch
as code owners
| @@ -188,7 +188,7 @@ export class ConfigureIRDialog { | |||
| }).component(); | |||
|
|
|||
| // get the SHIR script | |||
| const scriptPath = path.join(__dirname, '../../../scripts/SHIR-auto-configuration.ps1'); | |||
| const scriptPath = path.join(__dirname, '../../scripts/SHIR-auto-configuration.ps1'); | |||
There was a problem hiding this comment.
What is root directory from where we are trying this relative path? is it ".azuredatastudio-rc1\extensions\microsoft.sql-migration-1.5.4\migrationService\Windows\4.12.0.4"?
Ramudaykumar
approved these changes
Feb 29, 2024
Pull Request Test Coverage Report for Build 8093759514Details
💛 - Coveralls |
|
Merging on behalf of Ramya. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugs fixed: