Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filestream filegroups table conversion #25477

Merged
merged 5 commits into from
Mar 5, 2024
Merged

Filestream filegroups table conversion #25477

merged 5 commits into from
Mar 5, 2024

Conversation

smartguest
Copy link
Contributor

@smartguest smartguest commented Mar 5, 2024 •
edited
Loading

Part of the required conversions to Declarative Table.

Part of issues:
#25209
#25210
#25131
#25130

FilestreamFilegroup

kisantia
kisantia approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@kisantia kisantia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please mention the issue this addresses in the PR description

extensions/mssql/src/objectManagement/ui/databaseDialog.ts Outdated Show resolved Hide resolved
extensions/mssql/src/objectManagement/ui/databaseDialog.ts Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8149394781

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 41.757%
Totals Coverage Status
Change from base Build 8148544474: 0.001%
Covered Lines: 30827
Relevant Lines: 69082
💛 - Coveralls

@smartguest smartguest merged commit 8b1b231 into main Mar 5, 2024
14 checks passed
@smartguest smartguest deleted the alex/filestreamFilegroupsTableConversion branch March 5, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisantia kisantia kisantia approved these changes

@corivera corivera Awaiting requested review from corivera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smartguest @coveralls @kisantia