Generate Template link and blob container dropdown fix #25553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2024 16:05
sahuroshan
requested review from
AkshayMata,
raymondtruong,
brian-harris and
junierch
as code owners
Pull Request Test Coverage Report for Build 8572925779Details
💛 - Coveralls |
Ramudaykumar
reviewed
Apr 4, 2024
extensions/sql-migration/src/dialog/skuRecommendationResults/SelectStorageAccountDialog.ts
Outdated
Show resolved
Hide resolved
Ramudaykumar
requested changes
Apr 4, 2024
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this PR 3 bugs have been fixed.
In the 3 page as well now latest sku recommendation are fetched(earlier the recommended sku was displayed based on older sku recommendation) and a loading... text is displayed until the latest sku recommendation are fetched . Doing this change fixed both of the bugs related to generate template link.
There was another bug , the ARM template was getting uploaded to the first blob container in the dropdown. Added an ondropdownchange event to fix the same.
ADO bug links-
https://msdata.visualstudio.com/Database%20Systems/_workitems/edit/3044065
https://msdata.visualstudio.com/Database%20Systems/_workitems/edit/3044076