Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload to blob container fix #25554

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Upload to blob container fix #25554

merged 2 commits into from
Apr 4, 2024

Conversation

sahuroshan
Copy link
Contributor

updated the node module version to fix the issue. This seems to be known issue with the older versions of azure/storage-blob module.

found similar issue here - Azure/azure-sdk-for-js#28059 (comment)

ADO bug link - https://msdata.visualstudio.com/Database%20Systems/_workitems/edit/3044065

@coveralls
Copy link

coveralls commented Apr 1, 2024

Pull Request Test Coverage Report for Build 8518043534

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.757%

Totals Coverage Status
Change from base Build 8511640437: 0.0%
Covered Lines: 30827
Relevant Lines: 69082

💛 - Coveralls

Copy link
Contributor

@Ramudaykumar Ramudaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a comment to test other blob scenarios.

@Ramudaykumar
Copy link
Contributor

Build has also failed, check if it is due to our change.

@sahuroshan
Copy link
Contributor Author

Build has also failed, check if it is due to our change.

Build has also failed, check if it is due to our change.

that was because i didn't run yarn command after updating package.json, it should go away now.

@sahuroshan sahuroshan merged commit 49d8c61 into main Apr 4, 2024
11 checks passed
@sahuroshan sahuroshan deleted the roshansahu/uploadToBlobFix branch April 4, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants