Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kusto STS version to 5.0.0.2 #25558

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Update Kusto STS version to 5.0.0.2 #25558

merged 3 commits into from
Apr 3, 2024

Conversation

kisantia
Copy link
Contributor

@kisantia kisantia commented Apr 2, 2024

Updating the version of STS that the Kusto extension uses to one that has signed dlls, since it got flagged in the new ADS Extensions pipeline. I did a quick check locally to make sure it downloads and the Kusto Service starts, but I'm not planning on releasing a new version of the Kusto extension. This change is just necessary to unblock the new ADS extension pipeline.

Too many differences to screenshot, but here's a link to the differences for the STS used by the Kusto extension: microsoft/sqltoolsservice@4.11.0.20...5.0.0.2

Also updating STS in mssql for consistency. Differences for STS used by mssql: microsoft/sqltoolsservice@4.12.0.3...5.0.0.2

@corivera
Copy link
Member

corivera commented Apr 2, 2024

Do we want to update the mssql STS version at the same time for consistency?

extensions/kusto/config.json Outdated Show resolved Hide resolved
@kisantia kisantia requested a review from kburtram as a code owner April 2, 2024 23:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8530715277

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 41.756%

Files with Coverage Reduction New Missed Lines %
src/sql/workbench/services/connection/browser/connectionDialogWidget.ts 1 73.44%
Totals Coverage Status
Change from base Build 8511640437: -0.001%
Covered Lines: 30826
Relevant Lines: 69082

💛 - Coveralls

@kisantia kisantia merged commit c305377 into main Apr 3, 2024
11 checks passed
@kisantia kisantia deleted the kisantia/updateKustoSTS branch April 3, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants