-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "New Python Installation" option in Configure Python dialog #25569
Conversation
Pull Request Test Coverage Report for Build 8637291071Details
💛 - Coveralls |
One question I had is whether it's worth it to still have that first "Edit" UX. Before it was used to cover up all the controls for New/Existing install to reduce clutter when python had already been configured, but now the page looks basically the same either way. @kisantia Your thoughts? |
To make sure I'm understanding the question - is it if the first screenshot scenario should be removed and it just always be the second screenshot? |
Correct |
That sounds good to me, especially if it helps simplify the code too. Any thoughts on this change @chlafreniere? |
I'll make that change in a subsequent PR to keep this one from getting more complicated. |
The current provided python package has gotten pretty old and is nontrivial to update, so we decided to deprecate the New Python Install option. We already automatically detect installed versions of python and also provide a guided experience to install required pip packages, so the only work a user would need to do is install python on their machine before using jupyter notebooks. I improved the automatic version detection as well, so it picks up more recent versions of python.
I also cleaned up some unused jupyter code in the machine-learning extension at the same time, since I already had to make some changes in that area as part of this larger work.
Screenshots of new dialog UX:
With python already setup
![EditPath](https://private-user-images.githubusercontent.com/12820011/321350923-85c55b1f-315a-47fb-8dc3-c15b7d56b324.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1NzgxMjAsIm5iZiI6MTcyMDU3NzgyMCwicGF0aCI6Ii8xMjgyMDAxMS8zMjEzNTA5MjMtODVjNTViMWYtMzE1YS00N2ZiLThkYzMtYzE1YjdkNTZiMzI0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEwVDAyMTcwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE2ZGQ0MGU3YWIyZTFiZWQ4NGY5YzZhYTUwNWViMTkzMjNhOGJjOWVhZDI4OGZhNzYwNzQzMDM1ZTM4NmUyMmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.rZMCKinRokXlaar6xtcms-ouhsrBUEfiogJEBs8u7hU)
When specifying different versions
![PathDropdown](https://private-user-images.githubusercontent.com/12820011/321351405-048b315e-fe86-4ee5-bfbc-34aa66291f54.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1NzgxMjAsIm5iZiI6MTcyMDU3NzgyMCwicGF0aCI6Ii8xMjgyMDAxMS8zMjEzNTE0MDUtMDQ4YjMxNWUtZmU4Ni00ZWU1LWJmYmMtMzRhYTY2MjkxZjU0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEwVDAyMTcwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI2Mjg5MWQzMDI1MWI0Y2QyYjk4NGI0ZTM3YmJmZTYwY2Q1OTA0M2RmNWFlMzJlMWM2NmQ1NGRhM2RhMmVlN2MmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Vr-f_CdVgqzip9ZdYV6rjMH-FZu5yuf2c9L_34bm0vU)