Fix to handle templates recommended in batches in case of SQL DB #25581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 11, 2024 16:09
sahuroshan
requested review from
AkshayMata,
raymondtruong,
brian-harris and
junierch
as code owners
Pull Request Test Coverage Report for Build 8660920157Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
| export const TARGET_PROVISIONING_TITLE = localize('sql.migration.target.provisioning.title', "Save Template"); | ||
| export const GENERATE_ARM_TEMPLATE = localize('sql.migration.target.provisioning.generate.template', "Generate Template"); | ||
| export const CLOSE_DIALOG = localize('sql.migration.target.provisioning.close', "Close"); | ||
| export const TARGET_PROVISIONING_DESCRIPTION = localize('sql.migration.target.provisioning.description', "Below is the ARM script for the recommended target SKU. You can save the script as template."); | ||
| export const DISPLAY_ARM_TEMPLATE_LIMIT = localize('sql.migration.target.provisioning.template.display.limit', "A single ARM template has a deployment limitation of a maximum 50 Azure SQL Databases. The template for the first 50 databases is displayed below. To view all templates, save the template JSON file in a local storage or Azure Blob storage.") |
There was a problem hiding this comment.
"A single ARM template has a deployment limitation of a maximum 256 parameters, so deploy in batches of 50 DBs."
This should be 1st sentence for correct msg, you may add this link as well. https://learn.microsoft.com/en-us/azure/azure-resource-manager/templates/best-practices#template-limits
Current msg is not correct as there is no limitation on number of DBs but it is on number of Parameters.
There was a problem hiding this comment.
this text was provided by abhishek. I think parameters in templates in very low level details of code that we are explaining to Cx.
...nsions/sql-migration/src/dialog/skuRecommendationResults/GenerateProvisioningScriptDialog.ts
Outdated
Show resolved
Hide resolved
extensions/sql-migration/src/dialog/skuRecommendationResults/SelectStorageAccountDialog.ts
Show resolved
Hide resolved
extensions/sql-migration/src/wizard/assessmentDetailsPage/assessmentDetailsHeader.ts
Outdated
Show resolved
Hide resolved
extensions/sql-migration/src/wizard/skuRecommendation/assessmentSummaryCard.ts
Outdated
Show resolved
Hide resolved
|
Overall, it looks good, please take comments and update SQLToolsService version with latest one. |
stuti149
reviewed
Apr 12, 2024
...nsions/sql-migration/src/dialog/skuRecommendationResults/GenerateProvisioningScriptDialog.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the assesed instance has more than 50 dbs then instead of one template we will be getting list of templates from the nuget, This PR is to handle that change only.
ADO task link - https://msdata.visualstudio.com/Database%20Systems/_workitems/edit/3100628