Change double-quote hygiene rule to tslint rule #6514
Conversation
| @@ -351,6 +338,17 @@ function hygiene(some) { | |||
| input = some; | |||
| } | |||
|
|
|||
| const tslintSqlConfiguration = tslint.Configuration.findConfiguration('tslint-sql.json', '.'); | |||
There was a problem hiding this comment.
Youy don't need to add this to the hygiene run, this will automatically run in the tslint check if you have the rule in the tslint directory and have the rule in the tslint file.
There was a problem hiding this comment.
If your goal is to limit the scope of the files included for this rule, I would just modify the tslint gulp task to run a second pass with just our lint file, rather than putting this into the hygiene task.
There was a problem hiding this comment.
You could also see if vscode has interest in taking this rule, since they have the guidance and when they change code they general update any code that doesn't follow the guidance, they probably just don't see this as big enough of a problem to dedicate time to fix.
There was a problem hiding this comment.
So I didn't add it to the tslint.json because that runs on all files and I didn't want to fix up the vscode ones since that'd just result in a bunch of changes that might cause issues merging down the line. Hence the creation of the new tslint file that will run on just the sql code. (I'll update it later to run on our extensions too - I just didn't want to do the changes now since the fix logic isn't working for some reason so I need to investigate that further and doing the replacements manually is a pain)
And I still want it to run as part of hygiene so that the precommit hook catches it - since my current understanding if I'm reading the configuration correctly is that it only runs the hygiene task as a precommit hook and thus if someone ignores the GCI failing (which people do quite a bit) they might not catch the issue.
I'll follow up with seeing if vscode will take this but for now I figure we can get it in our repo and then remove it later if they decide to take it.
No description provided.