Results grid options #962
Merged
Results grid options #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kburtram
approved these changes
Mar 22, 2018
kburtram
reviewed
Mar 22, 2018
package.json
Outdated
| @@ -32,7 +32,7 @@ | |||
| "@angular/router": "~4.1.3", | |||
| "@angular/upgrade": "~4.1.3", | |||
| "angular2-grid": "2.0.6", | |||
| "angular2-slickgrid": "git://github.com/Microsoft/angular2-slickgrid.git#1.3.9", | |||
| "angular2-slickgrid": "git://github.com/Microsoft/angular2-slickgrid.git#feat/setRowHeightRelease", | |||
There was a problem hiding this comment.
should this be updated to a tag off master?
There was a problem hiding this comment.
yeah I need to merge it in and update the release
There was a problem hiding this comment.
added 2 commits
March 22, 2018 16:27
kburtram
added a commit
that referenced
this pull request
Mar 24, 2018
anthonydresser
pushed a commit
that referenced
this pull request
Mar 24, 2018
kburtram
added a commit
that referenced
this pull request
Mar 26, 2018
kburtram
added a commit
that referenced
this pull request
Mar 26, 2018
|
Just installed Azure Data Studio 1.0.0, and tried modifying resultsGrid.rowHeight in user settings, with no effect, which I assume is because the code changes were reverted. Will you be revisiting this setting to try and get it implemented? It really would be a useful addition. Many thanks for an awesome tool! |
|
Results row height is not configurable, default of 29 is too space eating, unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds results grid options.
resultsGrid.rowHeightresultsGrid.cellPaddingresultsGrid.fontFamilyresultsGrid.fontSizeresultsGrid.fontWeightresultsGrid.letterSpacingneeds microsoft/angular2-slickgrid#28
fixes #761
fixes #181
maybe others, it's been asked for a lot