Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding XFS as a root filesystem type #5198

Merged
merged 4 commits into from Apr 10, 2023
Merged

Conversation

AZaugg
Copy link
Contributor

@AZaugg AZaugg commented Mar 31, 2023

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Adding XFS support to the installer, as well as allow Mariner to boot XFS filesystems.

Change Log
  • Added XFS option to Mariner Installer
  • Added fsck.xfs to initrd
  • Added XFS module to grub
Does this affect the toolchain?

YES

Test Methodology
  • Build a new VHD and booted, confirmed root filesystem was running XFS

@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Mar 31, 2023
@AZaugg AZaugg force-pushed the xfsroot branch 3 times, most recently from 1a8a4be to 4b22481 Compare April 5, 2023 23:36
@AZaugg AZaugg marked this pull request as ready for review April 5, 2023 23:41
@AZaugg AZaugg requested a review from a team as a code owner April 5, 2023 23:41
@AZaugg
Copy link
Contributor Author

AZaugg commented Apr 5, 2023

Not sure, if we want to add a default mount option of bigtime=1 for any XFS mount.

@dmcilvaney
Copy link
Contributor

dmcilvaney commented Apr 7, 2023

Looks good, just three things:

  1. Looks like Vince sniped you with an update to the initramfs package, so needs a rebase
  2. Could you add xfsprogs to the prerequisites doc
  3. I don't believe we need these in the toolchain, since it will use the 'host' tools to partition the disks

Copy link
Contributor

@dmcilvaney dmcilvaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added @chalamalasetty who tracks the size of our ISOs as a reviewer.

@chalamalasetty - Looking at the dependencies for xfsprogs I think we already have them all in the image, so the only effect is xfsprogs itself. (4.27MB)

Adding support to provision Mariner with a root filesystem
of type xfs
Insert the xfs module allowing grub to boot XFS
To support XFS adding xfsprogs into the mariner build
toolchain
- Removing xfsprogs from toolchain list
- adding xfsprogs to prereq documentation
@dmcilvaney
Copy link
Contributor

Added @chalamalasetty who tracks the size of our ISOs as a reviewer.

@chalamalasetty - Looking at the dependencies for xfsprogs I think we already have them all in the image, so the only effect is xfsprogs itself. (4.27MB)

Validated with a low memory device, seems fine still.

@dmcilvaney dmcilvaney merged commit 5d899b3 into microsoft:main Apr 10, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants