Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zstd from package test exclusion list #5545

Merged
merged 1 commit into from
May 22, 2023

Conversation

oliviacrain
Copy link
Contributor

@oliviacrain oliviacrain commented May 22, 2023

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

We have been skipping zstd tests since May 2020. Back then, we were on version 1.4.4, which had an issue with /dev/null having its ownership modified. That issue was fixed in version 1.4.5. Now that zstd is on version 1.5.0, we can start running the tests again.

Change Log
  • Stop excluding zstd tests in macros.override
Does this affect the toolchain?

NO

Test Methodology

@oliviacrain oliviacrain requested a review from a team as a code owner May 22, 2023 17:00
@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label May 22, 2023
@oliviacrain oliviacrain added the ptest package testing (%check section in spec) label May 22, 2023
Copy link
Contributor

@rikenm1 rikenm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oliviacrain oliviacrain merged commit 82b8009 into main May 22, 2023
9 checks passed
@oliviacrain oliviacrain deleted the olivia/zstd-test-enable branch May 22, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main ptest package testing (%check section in spec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants