Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable tests for gnutls, jna, libsoup, strongswan #6244

Merged
merged 1 commit into from Sep 20, 2023

Conversation

oliviacrain
Copy link
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Our test runner environment has changed drastically throughout the years and packages have been changed/upgraded, so we should re-evaluate tests that have been turned off in macros.override since the days of pre-1.0.

gnutls, libsoup: I can't track down the reason for these tests being disabled, but they seem to run without issues in our pipelines
jna: We no longer run tests for toolchain packages in the toolchain environment, so concerns over missing dependencies no longer apply.
strongswan: Test no longer hangs, most likely fixed by the solution to this issue

Change Log
  • Remove skip_check_* macros from macros.override for gnutls, jna, libsoup, strongswan
Does this affect the toolchain?

NO

Test Methodology

@oliviacrain oliviacrain requested a review from a team as a code owner September 20, 2023 17:16
@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Sep 20, 2023
@oliviacrain oliviacrain merged commit 56cc033 into main Sep 20, 2023
10 checks passed
@oliviacrain oliviacrain deleted the olivia/test-reenablement-1 branch September 20, 2023 22:19
cwyborny pushed a commit to cwyborny/CBL-Mariner that referenced this pull request Sep 29, 2023
cwyborny pushed a commit to cwyborny/CBL-Mariner that referenced this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants