Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating readme to describe the new default branch #177

Merged
merged 2 commits into from
Aug 3, 2018

Conversation

Evmaus-MS
Copy link

Updating the documentation slightly (and testing PR build validation).

@michaelcfanning
Copy link
Member

  1. Load and compile src\BinSkim.sln

this step is for developing changes 'Load and compile blah to develop changes to contribute.'


Refers to: README.md:8 in 34c1e87. [](commit_id = 34c1e87, deletion_comment = False)

@michaelcfanning
Copy link
Member

  1. Execute output in bld\bin\BinSkim.Driver for testing

This is wrong. S/be

'Run BuildAndTest.cmd from the enlistment root to validate all changes before proposing a pull request.'


Refers to: README.md:9 in 34c1e87. [](commit_id = 34c1e87, deletion_comment = False)

Copy link
Member

@michaelcfanning michaelcfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@michaelcfanning michaelcfanning merged commit 7038737 into develop Aug 3, 2018
@michaelcfanning michaelcfanning deleted the dev/Evmaus-MS/Develop-Branch-Change branch December 3, 2018 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants