Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Duplicate BondCodegen items were included" error message should mention EnableDefaultItems not EnableDefaultCompileItems #1110

Closed
chwarr opened this issue May 25, 2021 · 0 comments · Fixed by #1135
Closed

"Duplicate BondCodegen items were included" error message should mention EnableDefaultItems not EnableDefaultCompileItems #1110

chwarr opened this issue May 25, 2021 · 0 comments · Fixed by #1135
Labels
bug

Comments

@chwarr
Copy link
Member

chwarr commented May 25, 2021

The "Duplicate BondCodegen items were included" error message says that the EnableDefaultCompileItems property can be set to false to stop automatic inclusion. However, the automatic inclusion behavior is conditioned on the EnableDefaultItems property, not EnableDefaultCompileItems.

The error message should mention EnableDefaultItems instead.
@chwarr chwarr added the bug label May 25, 2021
chwarr added a commit to chwarr/bond that referenced this issue Feb 24, 2022
@chwarr
[c#] Refer to $(EnableDefaultItems) in dup codegen error
e927ec7 
The "Duplicate BondCodegen items were included" error message says that
the `$(EnableDefaultCompileItems)` property can be set to false to stop
automatic inclusion. The automatic inclusion behavior is conditioned on
the `$(EnableDefaultItems)` property, not
`$(EnableDefaultCompileItems)`.

Revise the error message to mention `$(EnableDefaultItems)`.

microsoft#1110
chwarr added a commit to chwarr/bond that referenced this issue Feb 24, 2022
@chwarr
[c#] Refer to $(EnableDefaultItems) in dup codegen error
223691b 
The "Duplicate BondCodegen items were included" error message says that
the `$(EnableDefaultCompileItems)` property can be set to false to stop
automatic inclusion. The automatic inclusion behavior is conditioned on
the `$(EnableDefaultItems)` property, not
`$(EnableDefaultCompileItems)`.

Revise the error message to mention `$(EnableDefaultItems)`.

Fixes microsoft#1110
@chwarr chwarr mentioned this issue Feb 24, 2022
Merged
chwarr added a commit that referenced this issue Feb 25, 2022
@chwarr
[c#] Refer to $(EnableDefaultItems) in dup codegen error
9c2e4dd 
The "Duplicate BondCodegen items were included" error message says that
the `$(EnableDefaultCompileItems)` property can be set to false to stop
automatic inclusion. The automatic inclusion behavior is conditioned on
the `$(EnableDefaultItems)` property, not
`$(EnableDefaultCompileItems)`.

Revise the error message to mention `$(EnableDefaultItems)`.

Fixes #1110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[c#] Refer to $(EnableDefaultItems) in dup codegen error chwarr/bond
1 participant
@chwarr