Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate partial classes for GRPC clients #672

Closed
FDUdannychen opened this issue Oct 27, 2017 · 2 comments
Closed

Generate partial classes for GRPC clients #672

FDUdannychen opened this issue Oct 27, 2017 · 2 comments

Comments

@FDUdannychen
Copy link

I suggest bond_over_grpc generates partial classes for clients (like protocol buffers), which allows adding properties/methods/interfaces to the clients.

public (partial) class FooClient : global::Grpc.Core.ClientBase<FooClient>

Currently a workaround is inheritance

public class MyFooClient : FooClient

The name of MyFooClient and its namespace are quite tricky.

@chwarr
Copy link
Member

chwarr commented Oct 27, 2017

No real concerns from me. If we start to generate a name that clashes with a name used in a partial class, that will cause the customer code to fail to compile, but there's no good way around that, and inheritance has a similar problem. (Types already work this way, but they're less likely to churn.)

Is this something you want to contribute?

  • Update templates in Haskell
  • Re-generated golden files
  • Add unit test demonstrating & testing new behavior
  • Update changelog

@chwarr
Copy link
Member

chwarr commented Feb 23, 2022

Given that Bond-over-gRPC is being deprecated and removed, I'm going to close this as "Won't Fix"

@chwarr chwarr added the wontfix label Feb 23, 2022
@chwarr chwarr closed this as completed Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants