Merge pull request #986 from Microsoft/stgum/ActivityPromptTests

add two ActivityPrompt tests for ResumeDialog and failed validation
microsoft · Sep 27, 2018 · 7a825ef · 7a825ef
2 parents b1f7541 + e675245
commit 7a825ef
Showing 1 changed file with 90 additions and 0 deletions.
diff --git a/tests/Microsoft.Bot.Builder.Dialogs.Tests/ActivityPromptTests.cs b/tests/Microsoft.Bot.Builder.Dialogs.Tests/ActivityPromptTests.cs
@@ -138,6 +138,96 @@ public async Task RetryAttachmentPrompt()
             .AssertReply("2")
             .StartTestAsync();
         }
+
+        [TestMethod]
+        public async Task ActivityPromptShouldReturnDialogEndOfTurnIfValidationFailed()
+        {
+            var convoState = new ConversationState(new MemoryStorage());
+            var dialogState = convoState.CreateProperty<DialogState>("dialogState");
+
+            var adapter = new TestAdapter()
+                .Use(new AutoSaveStateMiddleware(convoState));
+
+            var dialogs = new DialogSet(dialogState);
+
+            PromptValidator<Activity> validator = async (prompt, cancellationToken) =>
+            {
+                return false;
+            };
+
+            var eventPrompt = new EventActivityPrompt("EventActivityPrompt", validator);
+            dialogs.Add(eventPrompt);
+
+            var eventActivity = new Activity { Type = ActivityTypes.Event, Value = 2 };
+
+            await new TestFlow(adapter, async (turnContext, cancellationToken) =>
+            {
+                var dc = await dialogs.CreateContextAsync(turnContext, cancellationToken);
+                var results = await dc.ContinueDialogAsync(cancellationToken);
+                if (results.Status == DialogTurnStatus.Empty)
+                {
+                    var options = new PromptOptions { Prompt = new Activity { Type = ActivityTypes.Message, Text = "please send an event." } };
+                    await dc.PromptAsync("EventActivityPrompt", options);
+                }
+                else if (results.Status == DialogTurnStatus.Complete)
+                {
+                    var content = (Activity)results.Result;
+                    await turnContext.SendActivityAsync(content, cancellationToken);
+                } else if (results.Status == DialogTurnStatus.Waiting)
+                {
+                    await turnContext.SendActivityAsync("Test complete.");
+                }
+            })
+            .Send("hello")
+            .AssertReply("please send an event.")
+            .Send("test")
+            .AssertReply("Test complete.")
+            .StartTestAsync();
+        }
+
+        [TestMethod]
+        public async Task ActivityPromptResumeDialogShouldReturnDialogEndOfTurn()
+        {
+            var convoState = new ConversationState(new MemoryStorage());
+            var dialogState = convoState.CreateProperty<DialogState>("dialogState");
+
+            var adapter = new TestAdapter()
+                .Use(new AutoSaveStateMiddleware(convoState));
+
+            var dialogs = new DialogSet(dialogState);
+
+            PromptValidator<Activity> validator = async (prompt, cancellationToken) =>
+            {
+                return false;
+            };
+
+            var eventPrompt = new EventActivityPrompt("EventActivityPrompt", validator);
+            dialogs.Add(eventPrompt);
+
+            var eventActivity = new Activity { Type = ActivityTypes.Event, Value = 2 };
+
+            await new TestFlow(adapter, async (turnContext, cancellationToken) =>
+            {
+                var dc = await dialogs.CreateContextAsync(turnContext, cancellationToken);
+                var results = await dc.ContinueDialogAsync(cancellationToken);
+                if (results.Status == DialogTurnStatus.Empty)
+                {
+                    var options = new PromptOptions { Prompt = new Activity { Type = ActivityTypes.Message, Text = "please send an event." } };
+                    await dc.PromptAsync("EventActivityPrompt", options);
+                }
+                var secondResults = await eventPrompt.ResumeDialogAsync(dc, DialogReason.NextCalled);
+
+                if (secondResults.Status == DialogTurnStatus.Waiting)
+                {
+                    await turnContext.SendActivityAsync("Test complete.");
+                }
+            })
+            .Send("hello")
+            .AssertReply("please send an event.")
+            .AssertReply("please send an event.")
+            .AssertReply("Test complete.")
+            .StartTestAsync();
+        }
     }
 
     public class EventActivityPrompt : ActivityPrompt