Streaming: Surface exceptions like other paths to allow error handlin…

…g in upper layers. (#5803) (#5804)

* Streaming: Surface exceptions like other paths to allow error handling in upper layers.

* Fix typo

libraries/Microsoft.Bot.Builder/Streaming/StreamingRequestHandler.cs

@@ -403,28 +403,24 @@ public async Task<ResourceResponse> SendActivityAsync(Activity activity, Cancell
                 }
             }
 
-            try
+            if (!_serverIsConnected)
             {
-                if (!_serverIsConnected)
-                {
-                    throw new InvalidOperationException("Error while attempting to send: Streaming transport is disconnected.");
-                }
+                throw new InvalidOperationException("Error while attempting to send: Streaming transport is disconnected.");
+            }
 
-                var serverResponse = await _server.SendAsync(request, cancellationToken).ConfigureAwait(false);
+            // Attempt to send the request. If send fails, we let the original exception get thrown so that the 
+            // upper layers can handle it and trigger OnError. This is consistent with error handling in http and proactive 
+            // paths, making all 3 paths consistent in terms of error handling.
+            var serverResponse = await _server.SendAsync(request, cancellationToken).ConfigureAwait(false);
 
-                if (serverResponse.StatusCode == (int)HttpStatusCode.OK)
-                {
-                    return serverResponse.ReadBodyAsJson<ResourceResponse>();
-                }
+            if (serverResponse.StatusCode == (int)HttpStatusCode.OK)
+            {
+                return serverResponse.ReadBodyAsJson<ResourceResponse>();
             }
-#pragma warning disable CA1031 // Do not catch general exception types (this should probably be addressed later, but for now we just log the error and continue the execution)
-            catch (Exception ex)
-#pragma warning restore CA1031 // Do not catch general exception types
+            else
             {
-                _logger.LogError(ex.Message);
+                throw new Exception($"Failed to send request through streaming transport. Status code: {serverResponse.StatusCode}.");
             }
-
-            return null;
         }
 
         /// <summary>