Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back support for cards in prompts #1170

Closed
v-kydela opened this issue Nov 14, 2018 · 0 comments
Closed

Bring back support for cards in prompts #1170

v-kydela opened this issue Nov 14, 2018 · 0 comments
Labels
4.4 April 15, 2019 Release triaged Reviewed by the Triage Team

Comments

@v-kydela
Copy link
Contributor

v-kydela commented Nov 14, 2018 •
edited

Is your feature request related to a problem? Please describe.
While V3 allowed for cards in prompts, V4 does not. This is particularly a problem for channels that support cards but not suggested actions, like Cortana and Teams. Currently prompts only allow Inline, List, and SuggestedAction as styles. This can be seen in the Prompt and ChoiceFactory classes. At least one customer has run into issues because of this.

Describe the solution you'd like
V4 should be able to generate a card for a ChoicePrompt or ConfirmPrompt. This should probably be a hero card like it was in V3 for maximum compatibility. While I agree with this feature request that it would be nice to be able to explicitly choose cards as a style (which is lacking in both V3 and V4), it would be acceptable to at least allow cards as an automatically-selected option like they are in V3.

Describe alternatives you've considered
I've been able to work around the problem by creating a card manually as I did here.

Additional context
I am happy to implement this myself if that's acceptable.

[enhancement]
@v-kydela v-kydela mentioned this issue Nov 15, 2018
Closed
@vishwacsena vishwacsena added triaged Reviewed by the Triage Team 4.3 February 14, 2019 Release labels Nov 16, 2018
@v-kydela v-kydela mentioned this issue Dec 4, 2018
Closed
@benbrown benbrown added 4.4 April 15, 2019 Release and removed 4.3 February 14, 2019 Release labels Jan 28, 2019
@garypretty garypretty mentioned this issue Jan 29, 2019
Closed
@v-kydela v-kydela mentioned this issue Jan 29, 2019
Closed
garypretty added a commit to garypretty/botbuilder-dotnet that referenced this issue Jan 29, 2019
@garypretty
Added new HeroCard prompt style for ChoicePrompt as per microsoft#1170.…
6f53cbc 
… This is to provide support (other than plain text) for channels that do not support suggested actions, such as Teams.
garypretty added a commit to garypretty/botbuilder-dotnet that referenced this issue Jan 29, 2019
@garypretty
Revert "Added new HeroCard prompt style for ChoicePrompt as per micro…
36f615d 
…soft#1170. This is to provide support (other than plain text) for channels that do not support suggested actions, such as Teams."

This reverts commit 6f53cbc.
@garypretty garypretty mentioned this issue Jan 29, 2019
Merged
cleemullins added a commit that referenced this issue Jan 30, 2019
@cleemullins
Merge pull request #1339 from garypretty/choice-card-style
170e381 
Added new HeroCard prompt style for ChoicePrompt as per #1170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.4 April 15, 2019 Release triaged Reviewed by the Triage Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benbrown @vishwacsena @v-kydela