Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuthPrompt default timeout: 15 minutes or hours? #1307

Closed
v-kydela opened this issue Jan 24, 2019 · 2 comments
Closed

OAuthPrompt default timeout: 15 minutes or hours? #1307

v-kydela opened this issue Jan 24, 2019 · 2 comments
Assignees
Labels
4.3 February 14, 2019 Release bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing

Comments

@v-kydela
Copy link
Contributor

Version

master branch

Describe the bug

In OAuthPrompt.cs, it says the default prompt timeout is 15 minutes in milliseconds, but the value assigned to DefaultPromptTimeout is 15 hours and not 15 minutes:

    // Default prompt timeout of 15 minutes (in ms)
private const int DefaultPromptTimeout = 54000000;

15 minutes in milliseconds would be nine-hundred thousand instead of fifty-four million. I would submit a pull request myself but I am unsure which value was intended, so I don't know if the value needs to be updated or the comment. Please advise.

[bug]

@v-kydela
Copy link
Contributor Author

v-kydela commented Jan 24, 2019

I just checked the BotBuilder-JS repo and it also contains the 15-hour value, so if the value is wrong then it's wrong in both places. The BotBuilder-JS repo also says 15 minutes in the comments.

@sgellock sgellock added bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing Approved 4.3 February 14, 2019 Release labels Jan 25, 2019
@dmvtech dmvtech assigned v-kydela and unassigned dmvtech Jan 25, 2019
@dmvtech
Copy link
Collaborator

dmvtech commented Jan 25, 2019

Clarified this should be 15 minutes. Comment is correct, int value is incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.3 February 14, 2019 Release bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing
Projects
None yet
Development

No branches or pull requests

3 participants