You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In OAuthPrompt.cs, it says the default prompt timeout is 15 minutes in milliseconds, but the value assigned to DefaultPromptTimeout is 15 hours and not 15 minutes:
// Default prompt timeout of 15 minutes (in ms)
private const int DefaultPromptTimeout = 54000000;
15 minutes in milliseconds would be nine-hundred thousand instead of fifty-four million. I would submit a pull request myself but I am unsure which value was intended, so I don't know if the value needs to be updated or the comment. Please advise.
[bug]
The text was updated successfully, but these errors were encountered:
I just checked the BotBuilder-JS repo and it also contains the 15-hour value, so if the value is wrong then it's wrong in both places. The BotBuilder-JS repo also says 15 minutes in the comments.
sgellock
added
bug
Indicates an unexpected problem or an unintended behavior.
P1
Painful if we don't fix, won't block releasing
Approved
4.3
February 14, 2019 Release
labels
Jan 25, 2019
Version
master branch
Describe the bug
In OAuthPrompt.cs, it says the default prompt timeout is 15 minutes in milliseconds, but the value assigned to
DefaultPromptTimeout
is 15 hours and not 15 minutes:15 minutes in milliseconds would be nine-hundred thousand instead of fifty-four million. I would submit a pull request myself but I am unsure which value was intended, so I don't know if the value needs to be updated or the comment. Please advise.
[bug]
The text was updated successfully, but these errors were encountered: