Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Adaptive] Log to console generates trace with a label of 'BeginDialogAsync' #2913

Closed
darrenj opened this issue Nov 3, 2019 · 3 comments
Closed

[Adaptive] Log to console generates trace with a label of 'BeginDialogAsync' #2913

darrenj opened this issue Nov 3, 2019 · 3 comments
Assignees
@tomlm
Labels
P1 Painful if we don't fix, won't block releasing R8 Release 8 - March 16th, 2020
Projects
Adaptive
Milestone
R8

Comments

@darrenj
Copy link

darrenj commented Nov 3, 2019

When using the Log to Console Shape all trace events raised have a label of BeginDialogAsync which is confusing when it shows up in the Emulator as shown below

image

image

To Reproduce

image

Expected behavior

  • A more general name - potentially provided by the developer on the shape configuration or perhaps "Composer Trace"
@cwhitten cwhitten transferred this issue from microsoft/BotFramework-Composer Nov 4, 2019
@cwhitten cwhitten changed the title Log to console generates trace with a label of 'BeginDialogAsync' [Adaptive] Log to console generates trace with a label of 'BeginDialogAsync' Nov 4, 2019
@vishwacsena vishwacsena added P1 Painful if we don't fix, won't block releasing R7 Release 7 - December 10th, 2019 R8 Release 8 - March 16th, 2020 and removed R7 Release 7 - December 10th, 2019 labels Nov 9, 2019
@vishwacsena vishwacsena added this to P1 in Adaptive Dec 6, 2019
@github-actions
Copy link

github-actions bot commented Dec 9, 2019

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale The issue hasn't been updated in a long time and will be automatically closed. label Dec 9, 2019
@vishwacsena vishwacsena removed the stale The issue hasn't been updated in a long time and will be automatically closed. label Dec 11, 2019
@vishwacsena
Copy link
Contributor

Add a property label to TraceActivity action and include that as the label in the trace. Default value is Trace.

@vishwacsena vishwacsena assigned tomlm and unassigned vishwacsena Dec 18, 2019
@tomlm tomlm mentioned this issue Dec 20, 2019
Merged
@tomlm tomlm moved this from P1 to In Progress in Adaptive Dec 20, 2019
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale The issue hasn't been updated in a long time and will be automatically closed. label Jan 20, 2020
@darrenj darrenj removed the stale The issue hasn't been updated in a long time and will be automatically closed. label Jan 20, 2020
@tomlm tomlm closed this as completed Jan 23, 2020
Adaptive automation moved this from In Progress to Complete Jan 23, 2020
@munozemilio munozemilio added this to the R8 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomlm tomlm

Labels
P1 Painful if we don't fix, won't block releasing R8 Release 8 - March 16th, 2020
Projects
No open projects
Adaptive
Complete
Milestone
R8
Development

No branches or pull requests
5 participants
@cwhitten @tomlm @vishwacsena @darrenj @munozemilio