Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #2913 - Log and trace activity don't let you set the Label property #3183

Merged
merged 2 commits into from
Jan 6, 2020
Merged

Fix for issue #2913 - Log and trace activity don't let you set the Label property #3183

merged 2 commits into from
Jan 6, 2020

Conversation

tomlm
Copy link
Contributor

@tomlm tomlm commented Dec 20, 2019

#2913

  • added Label property to LogAction and TraceActivity

@tomlm tomlm added adaptive bug Indicates an unexpected problem or an unintended behavior. R8 Release 8 - March 16th, 2020 labels Dec 20, 2019
@coveralls
Copy link
Collaborator

coveralls commented Dec 20, 2019 •
edited

Pull Request Test Coverage Report for Build 97698

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1876 unchanged lines in 258 files lost coverage.
  • Overall coverage decreased (-0.01%) to 78.363%
Files with Coverage Reduction New Missed Lines %
/libraries/Adapters/Microsoft.Bot.Builder.Adapters.Facebook/FacebookAdapterOptions.cs 1 86.67%
/libraries/integration/Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/ApplicationBuilderExtensions.cs 1 71.43%
/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisApplication.cs 1 96.36%
/libraries/Microsoft.Bot.Builder.AI.LUIS/V3/LuisApplication.cs 1 96.43%
/libraries/Microsoft.Bot.Builder.AI.LUIS/V3/LuisUtil.cs 1 96.35%
/libraries/Microsoft.Bot.Builder/BotStateSet.cs 1 85.0%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/BaseInvokeDialog.cs 1 87.5%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/Case.cs 1 87.5%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/EditActions.cs 1 93.75%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/EndTurn.cs 1 81.82%
Totals Coverage Status
Change from base Build 97633: -0.01%
Covered Lines: 20640
Relevant Lines: 26339
💛 - Coveralls

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

@tomlm tomlm merged commit 5af677a into master Jan 6, 2020
This was referenced Jan 6, 2020
Closed
Closed
Closed
@tomlm tomlm deleted the tomlm/issue2913 branch January 6, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosscastro carlosscastro carlosscastro approved these changes

@vishwacsena vishwacsena Awaiting requested review from vishwacsena

Assignees
No one assigned
Labels
bug Indicates an unexpected problem or an unintended behavior. R8 Release 8 - March 16th, 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tomlm @coveralls @fuselabs @carlosscastro