Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspection middleware needs to be updated for Teams team chat #2955

Closed
Virtual-Josh opened this issue Nov 12, 2019 · 3 comments · Fixed by #2995
Closed

Inspection middleware needs to be updated for Teams team chat #2955

Virtual-Josh opened this issue Nov 12, 2019 · 3 comments · Fixed by #2995
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing R7 Release 7 - December 10th, 2019
Milestone

Comments

@Virtual-Josh
Copy link
Contributor

The inspection middleware intercept check needs to be updated to handle messages coming from Teams checking specifically for messages coming from a team.

@Virtual-Josh Virtual-Josh added bug Indicates an unexpected problem or an unintended behavior. teams R7 Release 7 - December 10th, 2019 labels Nov 12, 2019
@johnataylor
Copy link
Member

As it is today you can inspect one on one, inspect in group chat, however inside a Team you can only inpect the particular thread you originally attached to.

This seems like an unreasonable limitation. We should look at a better model, for example, consider the semantics of: once you are attached from anywhere inside a Team you are attached to everywhere (i.e. all threads and all channels) in that Team.

@johnataylor
Copy link
Member

JavaScript issue: microsoft/botbuilder-js#1406

@johnataylor
Copy link
Member

around here https://github.com/microsoft/botbuilder-dotnet/blob/master/libraries/Microsoft.Bot.Builder/Inspection/InspectionMiddleware.cs#L149

// if we are in a MS Teams Team then use the TeamId otherwise fall back to the ConversationId
var attachId = turnContext.Activity.TeamsGetTeamInfo()?.Id ?? turnContext.Activity.Conversation.Id;
if (AttachCommand(attachId, sessions, sessionId))
// etc. etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing R7 Release 7 - December 10th, 2019
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants