Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Inspection middlware needs to be updated to better handle activities from Teams #142

Closed
Virtual-Josh opened this issue Nov 12, 2019 · 1 comment
Closed

Inspection middlware needs to be updated to better handle activities from Teams #142

Virtual-Josh opened this issue Nov 12, 2019 · 1 comment
Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. bug Indicates an unexpected problem or an unintended behavior. P2 Nice to have
Projects
Bot Framework SDK - Code Quality (R10...

Comments

@Virtual-Josh
Copy link

The inspection middleware needs to be updated to better handle activities coming from Teams.

The conversation reference is too precise, we should use teamID if it exists, otherwise use the conversation reference.
@Virtual-Josh Virtual-Josh added bug Indicates an unexpected problem or an unintended behavior. teams labels Nov 12, 2019
@tracyboehrer
Copy link
Member

tracyboehrer commented Nov 12, 2019 •
edited

See microsoft/botbuilder-dotnet#2955
See #139

@clearab clearab added Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. P1 Painful if we don't fix, won't block releasing labels Jun 10, 2020
@axelsrz axelsrz added this to Issues waiting for Priority/Assignee in Bot Framework SDK - Code Quality (R10 Pillar) via automation Jun 15, 2020
@axelsrz axelsrz added investigate P2 Nice to have and removed P1 Painful if we don't fix, won't block releasing labels Jun 30, 2020
@axelsrz axelsrz moved this from Issues waiting for Priority/Assignee to Backlog in Bot Framework SDK - Code Quality (R10 Pillar) Jul 1, 2020
Bot Framework SDK - Code Quality (R10 Pillar) automation moved this from Backlog to Done Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. bug Indicates an unexpected problem or an unintended behavior. P2 Nice to have
Projects
No open projects
Bot Framework SDK - Code Quality (R10...
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tracyboehrer @clearab @axelsrz @Virtual-Josh