Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialogs.Declarative.Tests hang and give no message. #5713

Closed
BruceHaley opened this issue Jun 21, 2021 · 0 comments · Fixed by #5993
Closed

Dialogs.Declarative.Tests hang and give no message. #5713

BruceHaley opened this issue Jun 21, 2021 · 0 comments · Fixed by #5993
Assignees
@JuanAr
Labels
bug Indicates an unexpected problem or an unintended behavior. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@BruceHaley
Copy link
Contributor

BruceHaley commented Jun 21, 2021 •
edited

Running all tests on a new computer in Visual Studio, the tests hang indefinitely here:
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.4.3+1b45f5407b (64-bit .NET Core 4.6.30015.01)
[xUnit.net 00:00:03.36] Starting: Microsoft.Bot.Builder.Dialogs.Declarative.Tests

No message is given.

The cause: BF CLI was not installed.

Per Eric Dahlvang, the tests used to install BF CLI on the fly.
Related issues:
#4492
microsoft/botframework-sdk#6226

Suggested fix:

  1. A test be added that runs before the Dialogs.Declarative.Tests that fails if the prerequisite BF CLI is not installed.

  2. Set a timeout for Dialogs.Declarative.Tests at 60 seconds. (This normally completes after 20 seconds.)
@BruceHaley BruceHaley added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Jun 21, 2021
@thomas-chung thomas-chung added the ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. label Jun 22, 2021
@mrivera-ms mrivera-ms assigned JuanAr and unassigned mrivera-ms Jul 14, 2021
@sw-joelmut sw-joelmut mentioned this issue Nov 23, 2021
Merged
gabog pushed a commit that referenced this issue Jan 24, 2022
@sw-joelmut
[#5713] Dialogs.Declarative.Tests hang and give no message. (#5993)
7f3ada1 
* Add BotFramework-CLI prerequisite for Declarative tests

* Remove bf cli installation when an error occurs or the schema differs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
bug Indicates an unexpected problem or an unintended behavior. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#5713] Dialogs.Declarative.Tests hang and give no message. microsoft/botbuilder-dotnet
4 participants
@JuanAr @BruceHaley @thomas-chung @mrivera-ms