Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Streaming] Quality: Integration tests with legacy client + new server #5865

Closed
mrivera-ms opened this issue Aug 26, 2021 · 1 comment
Closed

[Streaming] Quality: Integration tests with legacy client + new server #5865

mrivera-ms opened this issue Aug 26, 2021 · 1 comment
Assignees
@carlosscastro @msomanathan
Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. Area: Streaming Issues related to streaming support P0 Must Fix. Release-blocker
Milestone
R15

Comments

@mrivera-ms
Copy link
Contributor

Parent issue: #5630
@mrivera-ms mrivera-ms added P0 Must Fix. Release-blocker Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. Area: Streaming Issues related to streaming support labels Aug 26, 2021
@mrivera-ms mrivera-ms added this to the R15 milestone Aug 26, 2021
@carlosscastro carlosscastro self-assigned this Sep 22, 2021
@carlosscastro
Copy link
Member

First E2E test with legacy client and new server is here: https://github.com/microsoft/botbuilder-dotnet/blob/feature/streaming-pipelines/tests/Microsoft.Bot.Connector.Streaming.Tests/Integration/InteropApplicationIntegrationTests.cs

And we already found a bug thanks to it related to json reader adding quotes around json and breaking the protocol.

This was referenced Oct 27, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlosscastro carlosscastro

@msomanathan msomanathan

Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. Area: Streaming Issues related to streaming support P0 Must Fix. Release-blocker
Projects
None yet
Milestone
R15
Development

No branches or pull requests
3 participants
@carlosscastro @msomanathan @mrivera-ms