Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-Pick: E2E tests for new streaming library (#5932) #5941

Merged
merged 1 commit into from Oct 29, 2021
Merged

Cherry-Pick: E2E tests for new streaming library (#5932) #5941

merged 1 commit into from Oct 29, 2021

Conversation

msomanathan
Copy link
Contributor

@msomanathan msomanathan commented Oct 29, 2021 •
edited

Fixes #5815 #5862 #5865 #5867

Cherry-pick #5932

@msomanathan @carlosscastro
E2E tests for new streaming library (#5932)
b4225de 
* E2E test infra with basic sample test.

* Activity tests with suggested actions and attachments.

* Chunk streams if > 3KB.

* Perf optimization when chunking of stream not needed.

* Crash/Disconnect/Cancellation tests.

* Refactor to enable concurrency testing.

* Concurrency test.

* Fix build break.

* Fix build break.

* Fix test failure.

* Pass CancellationToken in server and client.

* CancellationToken in BotFrameworkHttpAdapter.

* Fix test issue.

* Fix test.

* Optimize chunking for non-memory streams.

* Chunk optimization for MemoryStream

* Streaming: Add TimeOut centralized methods that are also debugger friendly (#5938)

* Streaming: add default timeout extension method that is debugger friendly

* Streaming session: clean up usings

* Streaming client: fix credentials

* Remove streaming library dependency on ASP.NET core Http. (#5937)

* Remove streaming library dependency on ASP.NET core Http.

* Remove Microsoft.AspNetCore.Connections.Abstractions dependency.

* Dispose socket.

* Dispose socket in StreamingConnection.

Co-authored-by: Carlos Castro <carlosscastro@users.noreply.github.com>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 275063

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 152 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.2%) to 78.75%
Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
/libraries/Microsoft.Bot.Builder/Streaming/StreamingRequestHandler.cs 5 68.18%
/libraries/Microsoft.Bot.Connector.Streaming/Application/LegacyStreamingConnection.cs 6 84.78%
/libraries/Microsoft.Bot.Connector.Streaming/Application/WebSocketStreamingConnection.cs 6 82.35%
/libraries/Microsoft.Bot.Connector.Streaming/Transport/TransportHandler.cs 6 96.36%
/libraries/Microsoft.Bot.Builder/Streaming/BotFrameworkHttpAdapterBase.cs 10 43.88%
/libraries/Microsoft.Bot.Connector.Streaming/Session/StreamingSession.cs 17 91.04%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/CloudAdapter.cs 20 72.5%
/libraries/Microsoft.Bot.Connector.Streaming/Transport/WebSocketTransport.cs 24 82.24%
Totals Coverage Status
Change from base Build 274618: 0.2%
Covered Lines: 24807
Relevant Lines: 31501
💛 - Coveralls

@msomanathan msomanathan merged commit 1fa6568 into 4.15 Oct 29, 2021
@msomanathan msomanathan deleted the msomanathan/cherrypick-streaming-e2etest branch October 29, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosscastro carlosscastro carlosscastro approved these changes

@stevengum stevengum Awaiting requested review from stevengum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@msomanathan @coveralls @carlosscastro