Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForEachElement breaks LG #6044

Closed
EricDahlvang opened this issue Dec 9, 2021 · 0 comments · Fixed by #6045
Closed

ForEachElement breaks LG #6044

EricDahlvang opened this issue Dec 9, 2021 · 0 comments · Fixed by #6045
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@EricDahlvang
Copy link
Member

@gabog discovered 4.15.1-rc0 will break existing bots. Greeting LG is not found.

Discussed with Carlos, and he mentioned the Services are probably not copied to the new child context and provided this fix:

                if (dc.Services != null)
                {
                    foreach (var service in dc.Services)
                    {
                        childDc.Services[service.Key] = service.Value;
                    }
                }
@EricDahlvang EricDahlvang added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Dec 9, 2021
@EricDahlvang EricDahlvang self-assigned this Dec 9, 2021
@EricDahlvang EricDahlvang removed the needs-triage The issue has just been created and it has not been reviewed by the team. label Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant