Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure services are copied to new child context in ForEachElement #6045

Merged
merged 1 commit into from Dec 9, 2021
Merged

Ensure services are copied to new child context in ForEachElement #6045

merged 1 commit into from Dec 9, 2021

Conversation

EricDahlvang
Copy link
Member

Fixes #6044

@EricDahlvang EricDahlvang requested a review from a team as a code owner December 9, 2021 16:33
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 281319

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.01%) to 78.643%
Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
/libraries/Microsoft.Bot.Connector.Streaming/Session/StreamingSession.cs 3 89.62%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/ForEachElement.cs 7 81.44%
Totals Coverage Status
Change from base Build 281006: -0.01%
Covered Lines: 24845
Relevant Lines: 31592
💛 - Coveralls

@EricDahlvang EricDahlvang merged commit 0d8cbac into main Dec 9, 2021
@EricDahlvang EricDahlvang deleted the eric/fixForEachElement branch December 9, 2021 16:57
This was referenced Dec 9, 2021
Closed
Closed
Closed
EricDahlvang added a commit that referenced this pull request Dec 9, 2021
@EricDahlvang
Ensure services are copied to new child context in ForEachElement (#6045
a15e001 
)
EricDahlvang added a commit that referenced this pull request Dec 9, 2021
@EricDahlvang
Ensure services are copied to new child context in ForEachElement (#6045
ec535a3 
) (#6046)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabog gabog gabog approved these changes

@carlosscastro carlosscastro carlosscastro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ForEachElement breaks LG
4 participants
@EricDahlvang @coveralls @gabog @carlosscastro