TelemetryLoggerMiddleware #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanisgrig
reviewed
Mar 6, 2019
| { | ||
| public static class TelemetryConstants | ||
| { | ||
| public const string ChannelIdProperty = "channelId"; |
There was a problem hiding this comment.
Should all telemetry properties follow the same casing? This middleware & the luis/qna samples use lower camel case. The waterfall telemetry & initializer is upper camel case.
There was a problem hiding this comment.
Argh.
The Initializer properties begin with lowercase, so we're already inconsistent. I'm leaning towards aligning with Initializer and begin with lowercase character - any thoughts?
Tempted to lowercase waterfall telemetry, but that's actually a breaking change.
In reply to: 263166401 [](ancestors = 263166401)
Pull Request Test Coverage Report for Build 51486
💛 - Coveralls |
daveta
changed the title
johnataylor
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Middlware component that uses IBotTelemetryClient to log events when messages are received/sent/updated or deleted in the bot.
Additional Details
https://github.com/daveta/analytics/blob/master/telemetry_enhancements/TelemetryEnhancements.md
js: microsoft/botbuilder-js#812