Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QnA Telemetry Support #1430

Merged
merged 3 commits into from
Mar 18, 2019
Merged

QnA Telemetry Support #1430

merged 3 commits into from
Mar 18, 2019

Conversation

daveta
Copy link
Contributor

@daveta daveta commented Mar 8, 2019

Adds Telemetry support to QnAMaker

Shares same pattern as Luis and TelemetryMiddleware.

  • Enables setting properties during GetAnswersAsync
  • Enables deriving from class and adding properties

https://github.com/daveta/analytics/blob/master/telemetry_enhancements/TelemetryEnhancements.md#telemetry-qna-recognizer

@coveralls
Copy link
Collaborator

coveralls commented Mar 8, 2019

Pull Request Test Coverage Report for Build 51419

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 74.806%

Files with Coverage Reduction New Missed Lines %
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/BotFrameworkHttpAdapter.cs 3 66.67%
/libraries/Microsoft.Bot.Builder.AI.QnA/QnAMaker.cs 8 96.57%
Totals Coverage Status
Change from base Build 50252: 0.2%
Covered Lines: 4056
Relevant Lines: 5422

💛 - Coveralls

@daveta daveta requested a review from ryanisgrig March 17, 2019 17:20
@daveta
Copy link
Contributor Author

daveta commented Mar 17, 2019

@ryanlengel : Latest should have naming you requested.. Can you approve?

@daveta daveta merged commit c7f8127 into master Mar 18, 2019
@cleemullins cleemullins deleted the daveta-telemetry-qna branch September 12, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants