Disable the "Live" token refresh tests #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleemullins
requested review from
johnataylor,
axelsrz,
carlosscastro and
munozemilio
|
Note: Can't merge this until the build passes. This branch build should now pass - if it doesn't I'll keep pulling on the thread until we know why. @JuanAr This build break seems unreleated to the ones in your branches. Those were related to XUnit packages not being pulled into the WebAPI tests. Those do not show up in master, at least not that I've seen yet. |
|
Further Note: There is a "P0" issue tagged with this PR. We can't ship until the tests are either re-enabled or @carlosscastro confirms this isn't a bug of some sort. This PR is a 100% short-term stop-gap. |
Pull Request Test Coverage Report for Build 51367
💛 - Coveralls |
johnataylor
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the Token Refresh tests, as they're all failing with what looks like a recent configuration error on the AAD side.
Related to #1480