Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StyleCop] Fix all the warning in Bot.Builder.Dialogs #1491

Merged
merged 1 commit into from
Mar 21, 2019
Merged

[StyleCop] Fix all the warning in Bot.Builder.Dialogs #1491

merged 1 commit into from
Mar 21, 2019

Conversation

ceciliaavila
Copy link
Collaborator

@ceciliaavila ceciliaavila commented Mar 18, 2019 •
edited by gasper-az

  • Add documentation for constructor and parameters

@ceciliaavila ceciliaavila mentioned this pull request Mar 18, 2019
Closed
@Aliandi @gasper-az
[StyleCop] Fix all the warning in Bot.Builder.Dialogs
971c715 
- Add documentation for constructor and parameters
- Remove trailing whitespaces
@gasper-az gasper-az force-pushed the fix/stylecop/Bot.Builder.Dialogs branch from 7c857a0 to 971c715 Compare March 19, 2019 18:38
@gasper-az gasper-az marked this pull request as ready for review March 19, 2019 18:39
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 51638

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 35 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 75.588%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs/WaterfallStepContext.cs 8 65.22%
/libraries/Microsoft.Bot.Builder.Dialogs/DialogContext.cs 27 72.73%
Totals Coverage Status
Change from base Build 51599: 0.0%
Covered Lines: 4304
Relevant Lines: 5694
💛 - Coveralls

@axelsrz axelsrz merged commit 6b6e32f into master Mar 21, 2019
@cleemullins cleemullins deleted the fix/stylecop/Bot.Builder.Dialogs branch September 12, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelsrz axelsrz axelsrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ceciliaavila @coveralls @axelsrz @Aliandi