Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StyleCop] Fix all the warnings on Builder.Azure.Tests #1500

Merged
merged 2 commits into from
Mar 22, 2019
Merged

[StyleCop] Fix all the warnings on Builder.Azure.Tests #1500

merged 2 commits into from
Mar 22, 2019

Conversation

ceciliaavila
Copy link
Collaborator

  • Add/remove spacing
  • Add trailing comma
  • Fix constant and non-constant fields order
  • Fix curly braces spacing
  • Remove prefix calls with base
  • Add documentation to enumeration items

@ceciliaavila ceciliaavila mentioned this pull request Mar 18, 2019
Closed
@coveralls
Copy link
Collaborator

coveralls commented Mar 20, 2019 •
edited

Pull Request Test Coverage Report for Build 51908

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.588%
Totals Coverage Status
Change from base Build 51712: 0.0%
Covered Lines: 4304
Relevant Lines: 5694
💛 - Coveralls

@ParadoxARG ParadoxARG marked this pull request as ready for review March 20, 2019 15:21
munozemilio
munozemilio suggested changes Mar 21, 2019
View reviewed changes
Copy link
Member

@munozemilio munozemilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just highlighted a small detail to keep consistency.

Thanks!

@munozemilio munozemilio merged commit 7534742 into master Mar 22, 2019
@munozemilio munozemilio deleted the fix/stylecop/Azure.Tests branch March 22, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gasper-az gasper-az gasper-az left review comments

@munozemilio munozemilio munozemilio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ceciliaavila @coveralls @munozemilio @gasper-az @Bill7zz