Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StyleCop] Fix warnings in Bot.Connetor.Test project #1508

Merged
merged 3 commits into from
Mar 22, 2019
Merged

[StyleCop] Fix warnings in Bot.Connetor.Test project #1508

merged 3 commits into from
Mar 22, 2019

Conversation

ceciliaavila
Copy link
Collaborator

  • Reorder using directives
  • Remove empty blank lines
  • Add trailing comma in multi-line initializers
  • Remove trailing white spaces
  • Update protected const fields to be protected property with private set.
  • Update private const field to be private read-only to avoid unreachable code in BaseTest class.

@ceciliaavila ceciliaavila mentioned this pull request Mar 18, 2019
Closed
@ParadoxARG ParadoxARG force-pushed the fix/stylecop/bot-connetor-test branch from cbbd063 to 1bbcef3 Compare March 19, 2019 20:43
@coveralls
Copy link
Collaborator

coveralls commented Mar 19, 2019 •
edited

Pull Request Test Coverage Report for Build 52014

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.588%
Totals Coverage Status
Change from base Build 51937: 0.0%
Covered Lines: 4304
Relevant Lines: 5694
💛 - Coveralls

@ParadoxARG ParadoxARG marked this pull request as ready for review March 19, 2019 20:57
munozemilio
munozemilio suggested changes Mar 21, 2019
View reviewed changes
Copy link
Member

@munozemilio munozemilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments in line.

Thanks!

@gasper-az gasper-az changed the title [StyleCop] Fix warnings in Bot.Connetor.Test project [DO NOT MERGE][StyleCop] Fix warnings in Bot.Connetor.Test project Mar 22, 2019
@gasper-az
Removed unused using
1201f08 
Add copyright in some files
@gasper-az gasper-az force-pushed the fix/stylecop/bot-connetor-test branch from 79c3aee to 1201f08 Compare March 22, 2019 17:05
@gasper-az
Change namespace Connector.Tests to Microsoft.Bot.Connector.Tests…
e93f653 
… in BotAccessTokenStub.cs

Add reference to `Microsoft.Bot.Connector.Tests` in the files where BotAccessTokenStub class is referenced
@gasper-az gasper-az changed the title [DO NOT MERGE][StyleCop] Fix warnings in Bot.Connetor.Test project [StyleCop] Fix warnings in Bot.Connetor.Test project Mar 22, 2019
@munozemilio munozemilio merged commit 88f401b into master Mar 22, 2019
@munozemilio munozemilio deleted the fix/stylecop/bot-connetor-test branch March 22, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gasper-az gasper-az gasper-az left review comments

@munozemilio munozemilio munozemilio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ceciliaavila @coveralls @munozemilio @gasper-az @Bill7zz